Francisco Giordano
Francisco Giordano
The problem is that often that's not really the useful value. Imagine that your counter is a nonce, you generally want it to start at 0, so you'd want the...
To clarify on `Initializable.sol`: this contract is now included in the OpenZeppelin Contracts packages: `@openzeppelin/contracts` and `@openzeppelin/contracts-upgradeable`. "Dependency hell" is not a good name for this discussion. Please try to...
Given that we want to explore batch minting in ERC721 it seems we should not merge this, as the assumption that minting happens one at a time will be invalidated....
inheritdoc is supported out of the box in solidity-docgen (here it is in [0.5](https://github.com/OpenZeppelin/solidity-docgen/blob/0.5/src/source.ts#L592) which is what we're using currently). Note that the way it works is it "copies all...
Yes we want to use `@param` but it's a lot of work.
Sorry folks the getters that return `uint256` were inherited from GovernorBravo and we defined them that way for compatibility with that contract. That hasn't changed so I think we should...
Following up on my previous comment. While the external getters should continue to return `uint256`, we can change the storage variables to use uint64 in order to more efficiently pack...
`assertIsContract` would be safe, but I'm not sure what it would be useful for. `isContract` is necessary to implement standards like ERC721 and ERC1155. Nowadays Solidity has `addr.code.lengh` that we...
@ashwinYardi Please open a PR against the `next` branch (future 5.0).
I'm really thinking we should just add `ERC20SafetyRails` (naming TBD) into the library. If we think this should be standard, that is one of the strongest ways to make the...