Francisco Giordano
Francisco Giordano
Thank you @hack3r-0m! I agree we should say in the documentation that `version` is hardcoded to `"1"`.
This is great content but it's too much to include in the Solidity file itself... I'm trying to figure out where else we can put it.
Thanks for the suggestion. Before submitting a PR, can you provide some more context? What is the use case that made you interested in this feature? If we implement this,...
Yes, it's very different. All that's needed is `_getVotes`. Please read the code and make sure you understand that. I'm concerned about the storage overhead that it will imply for...
I see. It's true that the quorum module becomes incompatible. With the approach I suggested I would include the quorum logic along with the custom `_getVotes` implementation. I'm not sure...
Compilation times double with this plugin. Currently it increases in this repo from 5 seconds to 11 or so. This will likely go down once we remove most of the...
Comments by @Amxx: > In some cases we want to test a modifier (see `AccessControlMock`) > Overloaded functions (like in `SafeMath`) are difficult test > How to test `StorageSlot`, also...
Closing in favor of #3666
That's interesting, this is the first time we hear about EIP-165 for EIP-721 receivers. The EIP doesn't seem to require it. If we add this in Governor we should add...
Thank you. This also applies to the ERC721 and ERC20 pages.