openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

Published 20 hours ago • verified publisher icon OpenZeppelin

ERC4626 Tracker should be part of release

Open jaglinux opened this issue 2 years ago • 2 comments

As per the discussion https://forum.openzeppelin.com/t/erc4626-vault-implementation-for-totalassets-in-base-contract/29474 and https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3497#issuecomment-1162864795 , requesting "ERC4626 Tracker" contract as part of release.

cc @Amxx

jaglinux avatar Jun 22 '22 19:06 jaglinux

Thanks @jaglinux for raising this issue.

We'll discuss that internally

Amxx avatar Jun 23 '22 09:06 Amxx

I don't think we should have this in the library. There are many ways in which totalAssets will be implemented in user code, and as far as I can tell this should not be a common one. The assets in the vault will generally be deployed somewhere, and the asset balance of the vault is meaningless in that case.

frangio avatar Jun 23 '22 20:06 frangio