Francisco Giordano
Francisco Giordano
Yes, for ERC20Votes. We need to document here: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/8ef7655e7b515a30c8b11ffc8d78fbf44bb6fe24/contracts/token/ERC20/extensions/ERC20Votes.sol#L141-L143 the format of the signature, i.e. that it's an EIP712 signature with certain fields and values. We can also add a...
We can consider adding a separate new function and making it our new recommendation.
Using unchecked arithmetic and array accesses on @Amxx's quicksort implementation seems to be more efficient than the heapsort implementation in this PR, at least in the array I'm testing with...
Away from the computer right now so I can't share the exact results. Definitely agree that the better worst case complexity of heap sort is a factor to consider. That...
What is needed to proceed here is to gain some more confidence that Quicksort would generally be more efficient, by running some more [benchmarks](https://github.com/frangio/gas-bench/tree/e76022b9fa8e13290b2200014d7bc58a6b7d0263): - An already sorted array, or...
Waiting for Web3.js support. https://github.com/ChainSafe/web3.js/issues/4235
I am not comfortable with overwriting the free memory pointer in this way. The Gitter discussion is not a strong enough guarantee. The reality is that this use of memory...
To be fair, this variable would only get read/written on mints and burns, so I wouldn't entirely rule out adding `totalSupply()` in `ERC1155Supply`. Before agreeing, I would like to understand...
@philipSKYBIT Can you confirm on a testnet Etherscan that if there is a `totalSupply()` method in an ERC1155 token Etherscan will show its value properly?