openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

Document use of delegateBySig

Open frangio opened this issue 4 years ago • 3 comments

We don't seem to have documentation for the format of the message that needs to be signed.

frangio avatar Oct 28 '21 18:10 frangio

@frangio is it for ERC20Votes ? (https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/extensions/ERC20Votes.sol#L144 ) I can add documentation for it, compound published good article on it https://medium.com/compound-finance/delegation-and-voting-with-eip-712-signatures-a636c9dfec5e

hack3r-0m avatar Dec 08 '21 09:12 hack3r-0m

Yes, for ERC20Votes. We need to document here:

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/8ef7655e7b515a30c8b11ffc8d78fbf44bb6fe24/contracts/token/ERC20/extensions/ERC20Votes.sol#L141-L143

the format of the signature, i.e. that it's an EIP712 signature with certain fields and values. We can also add a link to the article you shared!

A PR would be appreciated.

frangio avatar Dec 08 '21 22:12 frangio

Any update on this? I think I don't see it in the tests for Governance either.

crazyrabbitLTC avatar Mar 28 '22 20:03 crazyrabbitLTC