openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard
verified publisher icon OpenZeppelin

TimelockController: Use default admin role

Open frangio opened this issue 3 years ago • 2 comments

TimelockController currently uses a custom non-zero TIMELOCK_ADMIN role that has complicated the introduction of the new CANCELLER_ROLE in 4.6 and necessitated a custom migration to set the role admin that would not have been necessary had DEFAULT_ADMIN_ROLE been used.

Moving forward we should always use the default admin role rather than custom roles.

frangio avatar May 02 '22 19:05 frangio

Hi! Does this issue need a pr?

Niceural avatar Jul 16 '22 17:07 Niceural

It's a breaking change so we're not doing it yet.

frangio avatar Jul 18 '22 21:07 frangio

Fixed by https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3799 for future 5.0 release.

frangio avatar Dec 02 '22 00:12 frangio