Felix Lange

Results 442 comments of Felix Lange

Not sure if we actually need the accessor on `enode.Node` at this point. We can keep `QUICEndpoint` but make it query the ENR directly instead of caching the port.

This happens when the macOS firewall is enabled. We cannot fix this issue, but we could work around it by using a random, OS-assigned port by default.

@gballet was assigned because he has a Ledger to test this with.

Sorry, hiveview is not ported to Windows right now.

I'm proposing this just because it's weird to duplicate a potentially large chainID in every authorization tuple. The chainID value will always be zero or equal to the tx chainID....

No, because the signed-over data still contains the chainID, and it will be verified with the chainID of the executing chain.

Hey @KolbyML, it's actually np to have the big PR, I'm just very slow.

I have changed the setting in CircleCI

I have merged the simulators as-is. However, I think there are some things that could be improved: - The simulator names are very long. It might be better to remove...

Looking at the simulators again, I also noticed the actual suite implementations are kind of small. One thing to note is that there is no one-to-one correspondence between simulators and...