Felix Lange
Felix Lange
``` eth/tracers/native/call_flat.go:299:45: unnecessary conversion (unconvert) CreationMethod: strings.ToLower(vm.OpCode(input.Type).String()), ^ ``` please fix the lint issue
I think it makes more sense to use the label that was used before, and not create a new tracing format.
Indeed, the goal is for clients to pass all tests. I don't want to add too many columns in the table. DataTables doesn't handle it super well on smaller screens....
Hope I didn't discourage you from making a PR. Definitely open to trying things out!
I guess this works because the logger calls `Enabled` first to check for the fast path.
BTW, any reason why we are not forwarding the context parameter into the sub-logger?
I think it's not worth to add like this. There might be a way to avoid the allocation though: since the stack is just `[]uint256.Int`, and may have capacity left...
Code above could probably be simplified to just use `append` instead of checking for available `cap` explicitly. However, using `append` will zero the `Int` in the slice, which we don't...
I would say let's try to get @holiman's contiguous_stack branch up to date. It's a very promising approach.