Felix Lange

Results 442 comments of Felix Lange

Something to note: the implementation here was copied from crypto/subtle, and it has some preconditions which are missing here. Importantly, the assembly code assumes the input slices do not have...

I still think it's bad. At least we should document the requirements more clearly. And possibly there should be checks on it. When using `subtle.XORBytes`, it will panic if the...

Do you have access to the metric `system_cpu_goroutines` emitted by geth? If it shows a steady increase in the same period, it would give us a hint.

OK, so it's not a leak at least.

Hi @come-maiz, I do not fully understand your concerns regarding Debian packaging. Please elaborate on the build process used. If possible, please also link to packaging scripts that you are...

I still think packaging all dependencies separately for Debian sounds like a nightmarish effort. Yes, one could in theory review all the diffs of all dependencies. But in practice, this...

I disagree that we have too many direct dependencies. We have been diligent about this, there are no unnecessary ones. Regarding upgrading dependencies, it is not in our intention to...

For the wider picture, I think it could also be worth looking into an alternative to running full Geth inside of the TEE. I doubt you need to run RPC...

I really like the idea, and the integration is done well in package internal/debug. We will deploy Pyroscope internally to try this.

Yes we need the auth. In our setups, we will typically report metrics across the Internet, talking to a public https endpoint with authentication.