Felix Lange

Results 442 comments of Felix Lange

I have to say, I find this extremely annoying as well. We use urfave/cli in go-ethereum, and are kind of stuck with it because we have so much code relying...

We have test cases for RPC endpoints here: https://github.com/ethereum/execution-apis/tree/main/tests Your tests should be added there. @lightclient

I think we can fix these warnings by also setting `-tags osusergo`.

Actually, it needs to be `-tags netgo,osusergo`. These build tags disable the use of cgo in packages "net" and "os/user".

I have tested this and it works now. Enabling static linking in our Docker builds has a key advantage: you can copy the executable into another container without worrying about...

This is ready for testing now. The cache size is configurable via `--cache.logcache` or in TOML with `Eth.FilterLogCacheSize = 128`, for example. @holiman Please re-check this, the PR has changed...

@ryanschneider did you test the PR yet?

A theory why it *could be* slow: In geth v1.10.20, we upgraded to a broken version of leveldb which may skip database compaction in some cases. When you upgrade to...

Note for potential contributors: this issue is not actionable immediately since we will wait for a while to fully adopt Go 1.18 and generics. Please do not submit PRs for...