Felix Lange
Felix Lange
After merging #28617, this error should not occur anymore since the management of snapshot has changed completely. However, we were never able to reproduce the issue ourself, and thus the...
I've been assigned on this PR for a while, and I think it would've been a good idea back then. But it looks like we can no longer rely on...
I would prefer to take care of this in the config2 refactoring https://github.com/ethereum/go-ethereum/pull/32224
We use some other packages from golang.org/x/crypto still
This is not possible, the cache could become invalidated by a change signature values. But we can add a cache in types.Transaction instead.
I think what we should do is, store a list of pre-derived authorizations (i.e. auth + address) in `core.Message` instead of`[]types.SetCodeAuthorization`. We can add a method to `types.Transaction` that returns...
The main idea is being able to use the cache. The cache in `types.Transaction` should contain the derived addresses of all authorizations in the tx. Another benefit is that deriving...
I think it's OK. We can handle the case of invalid authorizations by dropping them, and possibly by storing a secondary flag that indicates whether any invalid authorizations were present.
We are not merging the PR as-is. I already explained why.
Specifying the block hash using a JSON object was introduced by https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1898.md which is a Final status EIP. So it should be added into the execution-api spec. We can put...