go-ethereum icon indicating copy to clipboard operation
go-ethereum copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

p2p/enode: add quic ENR entry

Open guillaumemichel opened this issue 1 year ago • 2 comments

Add quic entry to the ENR as proposed in https://github.com/ethereum/consensus-specs/pull/3644

Allowing to read Lighthouse quic port from ENR.

guillaumemichel avatar Aug 09 '24 11:08 guillaumemichel

Not sure if we actually need the accessor on enode.Node at this point. We can keep QUICEndpoint but make it query the ENR directly instead of caching the port.

fjl avatar Aug 09 '24 11:08 fjl

I added a few more tests here. It didn't seem like the included test was really verifying the port was loaded correctly. Also verifying we don't return an endpoint with a quic6 port for IPv4 and vice versa. Not sure how important that is.

lightclient avatar Aug 18 '24 22:08 lightclient

Any update on the status of this PR?

cortze avatar Sep 02 '24 14:09 cortze

Is the PR good for merge?

guillaumemichel avatar Sep 12 '24 13:09 guillaumemichel