Yoshiki Fujikane comments

Results 110 comments of


                                            Yoshiki Fujikane

promtool tsdb analyze maps whole db, but only looks at one block

@bobrik @gouthamve Hi! I'd like to work on this!

fix: get block by id directly on promtool analyze

Ready for review🙇‍♂️

fix: get block by id directly on promtool analyze

@dgl @codesome I forgot to tell you how fix it🙇 - Added `*DBReadOnly.Block(logger log.Logger, blockID string)` to get block by id without getting all blocks. - Use the method when...

Modified to use Git with PAT

@sZma5a Sorry for closing this PR regardless of your contribution 🙏 I reopened it. It is because our GitHub actions automatically close PRs when keeping open with no activity 🙏...

Modified to use Git with PAT

@sZma5a OK ! Thank you for the quick reply 👍 If you want to, feel free to push the re-review on the right side :)

Modified to use Git with PAT

@sZma5a Thank you for the fix! I'm checking 👍

Check or reset the ID/PW of a project once registered when forgetting them

@dgannon991 Thank you! Please give it a try :) First, I would like to reconsider how to deal with this issue. I re-evaluated the situation and thought about how to...

Check or reset the ID/PW of a project once registered when forgetting them

@t-kikuc Thanks, closed

Remove checking the resource key with the annotation because their generation logic are different

I checked the prune behavior like below. ## cluster scoped resource - ✅ namespace exists in app.pipecd.yaml　 - ✅ namespace doesn't exist in app.pipecd.yaml ## namespace scoped resource - ✅...

Remove checking the resource key with the annotation because their generation logic are different

There is a problem about the resource key of cluster scoped resources. I'll consider it later to modify the effect scope.