prometheus icon indicating copy to clipboard operation
prometheus copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

fix: get block by id directly on promtool analyze

Open ffjlabo opened this issue 2 years ago • 2 comments

related issue: https://github.com/prometheus/prometheus/issues/10822

ffjlabo avatar Nov 03 '22 09:11 ffjlabo

Ready for review🙇‍♂️

ffjlabo avatar Nov 04 '22 14:11 ffjlabo

@dgl @codesome I forgot to tell you how fix it🙇

  • Added *DBReadOnly.Block(logger log.Logger, blockID string) to get block by id without getting all blocks.
  • Use the method when blockID is specified on promtool analyze.

ffjlabo avatar Nov 08 '22 16:11 ffjlabo

We have discussed this pull request during our bug scrub and we believe that it has been implemented in #12031. Please reopen if that is not the case.

Thank you for your contribution.

roidelapluie avatar Jul 11 '23 11:07 roidelapluie