Yoshiki Fujikane
Yoshiki Fujikane
## Kind; trigger - Trigger mainly creates a deployment based on commands. - There are two purposes for using kind 1. Add Kind to Deployment https://github.com/pipe-cd/pipecd/blob/44cfc932b2061f4cfbdbd134c912543919b1119d/pkg/app/piped/trigger/deployment.go#L80 2. Load Application config...
## Kind; server **The purpose of the component** - Server providers the gRPC API for web and other client (pipectl for now). - It uses Kind in the situations below....
### Kind; Metrics **The purpose of the component** The metrics `deployment_status` is affected because it has the label `application_kind`. https://github.com/pipe-cd/pipecd/blob/548a804d344d7c5faa70bcb6bd0889aa2a9269af/pkg/app/piped/controller/controllermetrics/metrics.go#L23C1-L40C2 ```js deployment_status{application_id="xxxxxxxx",application_kind="KUBERNETES",application_name="simple",deployment="xxxxxxx",instance="127.0.0.1:9085",job="pipecd-ops",launcher_version="v0.49.2",pipecd_component="piped",piped="xxxxx",piped_version="v0.49.2",platform_provider="kubernetes",project="test",status="DEPLOYMENT_CANCELLED"} ``` **Modification idea** - Use `model.Application.Labels["kind"]` instead of...
## Kind; planner **The purpose of the component** - Planner builds the deployment pipeline based on the app config. - Currently piped use the kind for three purpose 1. Collect...
### Kind; scheduler **The purpose of the component** - Scheduler controls the plan and deployment flow. - Currently piped use the kind in it for four purpose 1. Show log...
**Workaround**: create a dummy values.yaml and specify it with `helmCharts[].valuesFile` in `kustomization.yaml`. ```yaml # values.yaml test: dummy ``` ```yaml # kustomization.yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization helmCharts: - name: karpenter-crd version:...
I investigated the root cause. Here is what I found. - If helmCharts[].valuesFile is not set, it defaults to assuming a values.yaml exists in the local Helm chart. https://github.com/kubernetes-sigs/kustomize/blob/168971a50110fc90dfbd1327245e7aabe5c07e8f/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go#L110-L115 -...
I think it would be better to modify the process to account for Helm chart without values.yaml. If this approach is acceptable, I am considering trying to implement this fix....
@koba1t Thank you for checking! I will try it.