Yoshiki Fujikane

Results 110 comments of Yoshiki Fujikane

Thank you for asking. @Warashi 's idea seems to have two purposes. - to unify the process to get users and groups in the same method - to unify the...

@Warashi I agree with using the interface. Also, I got another concern 🙏 I think there are two processes in the `GetApplicationNotificationMentions`. - get the value (type `*config.DeploymentNotification`) from the...

After the investigation, I found out the way is possible. 👍 I will implement it later. **Detail** As the official document, `os/exec` package executes the command as a new process....

close this PR because I decided another solution for it. context: https://github.com/pipe-cd/pipecd/issues/4269#issuecomment-2104055928 follow the PR → https://github.com/pipe-cd/pipecd/pull/4916

I updated the TODO above. These are based on the investigation of the github action workflow definitions and previous PRs for updating go version. workflow definitions: .github/workflows/* to 1.20.3 -...

This happens because the custom alert template is parsed as Golang's text/template when parsing the encryptionSecret (from PipeCD).

Workaround: 1. Use a Secret resource for `.encryptedSecrets.key` and don't use it on a file. 2. Surround the part of the alert templating string by `{{``}}`. The surrounded part is...

@dgannon991 Thank you so much for the quick response!! The button UI is LGTM for me :) Thanks to your PR, I noticed this action is extremely dangerous because the...

@dgannon991 @khanhtc1202 > How about asking the user to reinstate the project name as part of the reset password confirmation page? (Cloud service like AWS use that method as re-check...

@dgannon991 Thank you for the nice commitment :) I also agree the ops pages are plain because these are for technical users. [IMO] If possible, it would be nice to...