Modified to use Git with PAT
What this PR does / why we need it: Modified to use Personal Access Token since currently only SSH can control the Git repository.
Which issue(s) this PR fixes:
Fixes #4106
Does this PR introduce a user-facing change?: Yes
- How are users affected by this change: Be able to use Personal Access Token setting like this:
apiVersion: pipecd.dev/v1beta1
kind: Piped
spec:
git:
personalAccessToken:
userName: <user-name>
userToken: <user-token>
- Is this breaking change: No
- How to migrate (if breaking change):
@kentakozuka
Sorry... I accidentally closed a previously created PR, but was unable to reopen it, so I created a side...
https://github.com/pipe-cd/pipecd/pull/4534
Codecov Report
Attention: Patch coverage is 54.16667% with 22 lines in your changes missing coverage. Please review.
Project coverage is 28.93%. Comparing base (
14eb473) to head (87be877). Report is 37 commits behind head on master.
:exclamation: Current head 87be877 differs from pull request most recent head 1291bab
Please upload reports for the commit 1291bab to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| pkg/git/client.go | 40.00% | 12 Missing and 3 partials :warning: |
| pkg/app/piped/cmd/piped/piped.go | 0.00% | 4 Missing :warning: |
| pkg/config/piped.go | 84.21% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #4571 +/- ##
==========================================
- Coverage 29.23% 28.93% -0.30%
==========================================
Files 318 317 -1
Lines 40597 40413 -184
==========================================
- Hits 11870 11695 -175
+ Misses 27787 27786 -1
+ Partials 940 932 -8
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.
@sZma5a Sorry for closing this PR regardless of your contribution ๐ I reopened it. It is because our GitHub actions automatically close PRs when keeping open with no activity ๐
How is your current situation? (e.g. Is this PR ready for Review?) If you have any trouble, please feel free to ping me :)
@ffjlabo Sorry... I forgot to add a mentions... I will work on it as soon as I receive your reply. https://github.com/pipe-cd/pipecd/pull/4571#discussion_r1429203747
@sZma5a OK ! Thank you for the quick reply ๐ If you want to, feel free to push the re-review on the right side :)
@kentakozuka I would appreciate it if you could check this at your convenience.
@sZma5a Sorry for the annoying DCO ๐ Could you re sign your last 3 commits ๐
Sorry for the delay in response. I will sign it later.
@sZma5a Thank you for the fix! I'm checking ๐
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
May I merge this PR ?
@sZma5a Sorry for pinging again and again. ๐ Would you happen to have any updates on the above? If you want some help, feel free to ping us ๐