pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Modified to use Git with PAT

Open sZma5a opened this issue 2 years ago โ€ข 17 comments

What this PR does / why we need it: Modified to use Personal Access Token since currently only SSH can control the Git repository.

Which issue(s) this PR fixes:

Fixes #4106

Does this PR introduce a user-facing change?: Yes

  • How are users affected by this change: Be able to use Personal Access Token setting like this:
apiVersion: pipecd.dev/v1beta1
kind: Piped
spec:
  git:
     personalAccessToken:
        userName: <user-name>
        userToken: <user-token>
  • Is this breaking change: No
  • How to migrate (if breaking change):

sZma5a avatar Aug 27 '23 16:08 sZma5a

@kentakozuka

Sorry... I accidentally closed a previously created PR, but was unable to reopen it, so I created a side...

https://github.com/pipe-cd/pipecd/pull/4534

sZma5a avatar Aug 27 '23 16:08 sZma5a

Codecov Report

Attention: Patch coverage is 54.16667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 28.93%. Comparing base (14eb473) to head (87be877). Report is 37 commits behind head on master.

:exclamation: Current head 87be877 differs from pull request most recent head 1291bab

Please upload reports for the commit 1291bab to get more accurate results.

Files Patch % Lines
pkg/git/client.go 40.00% 12 Missing and 3 partials :warning:
pkg/app/piped/cmd/piped/piped.go 0.00% 4 Missing :warning:
pkg/config/piped.go 84.21% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4571      +/-   ##
==========================================
- Coverage   29.23%   28.93%   -0.30%     
==========================================
  Files         318      317       -1     
  Lines       40597    40413     -184     
==========================================
- Hits        11870    11695     -175     
+ Misses      27787    27786       -1     
+ Partials      940      932       -8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '23 21:08 codecov[bot]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 14 '23 00:12 github-actions[bot]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 21 '24 00:01 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.

github-actions[bot] avatar Jan 29 '24 00:01 github-actions[bot]

@sZma5a Sorry for closing this PR regardless of your contribution ๐Ÿ™ I reopened it. It is because our GitHub actions automatically close PRs when keeping open with no activity ๐Ÿ™

How is your current situation? (e.g. Is this PR ready for Review?) If you have any trouble, please feel free to ping me :)

ffjlabo avatar Jan 29 '24 00:01 ffjlabo

@ffjlabo Sorry... I forgot to add a mentions... I will work on it as soon as I receive your reply. https://github.com/pipe-cd/pipecd/pull/4571#discussion_r1429203747

sZma5a avatar Jan 30 '24 02:01 sZma5a

@sZma5a OK ! Thank you for the quick reply ๐Ÿ‘ If you want to, feel free to push the re-review on the right side :)

Modified_to_use_Git_with_PAT_by_sZma5a_ยท_Pull_Request__4571_ยท_pipe-cd_pipecd

ffjlabo avatar Jan 30 '24 02:01 ffjlabo

@kentakozuka I would appreciate it if you could check this at your convenience.

sZma5a avatar Feb 14 '24 05:02 sZma5a

@sZma5a Sorry for the annoying DCO ๐Ÿ˜“ Could you re sign your last 3 commits ๐Ÿ™

khanhtc1202 avatar Apr 18 '24 06:04 khanhtc1202

Sorry for the delay in response. I will sign it later.

sZma5a avatar Apr 18 '24 14:04 sZma5a

@sZma5a Thank you for the fix! I'm checking ๐Ÿ‘

ffjlabo avatar Apr 19 '24 02:04 ffjlabo

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 10 '24 00:06 github-actions[bot]

May I merge this PR ?

sZma5a avatar Jul 04 '24 04:07 sZma5a

@sZma5a Sorry for pinging again and again. ๐Ÿ™ Would you happen to have any updates on the above? If you want some help, feel free to ping us ๐Ÿ‘

ffjlabo avatar Jul 30 '24 05:07 ffjlabo