fanquake
fanquake
Guix Build (x86_64 & aarch64): ```bash c27a601dbc89ed3abccb6f742178f15f0eb256cd5086d8360dd6727c9c866cab guix-build-a4e17239ca54/output/aarch64-linux-gnu/SHA256SUMS.part 0fdb1ff5320398ec5cf6378f72c826c619909e1079a9e8ab871bac938db41c0e guix-build-a4e17239ca54/output/aarch64-linux-gnu/bitcoin-a4e17239ca54-aarch64-linux-gnu-debug.tar.gz 60f6d4f34f3d5af5aeb6cf678a6f2ca60035d52cf8c48b3dbea7a54a8ce89776 guix-build-a4e17239ca54/output/aarch64-linux-gnu/bitcoin-a4e17239ca54-aarch64-linux-gnu.tar.gz be804999c04a0b68aae2fb98d855940c9629ede7d915b061f266576d3449d8bb guix-build-a4e17239ca54/output/arm-linux-gnueabihf/SHA256SUMS.part 3b4d1dfcdca2bc4e7ad1a5cc843171e57020e51e2e1c4c7c9247019b2698c352 guix-build-a4e17239ca54/output/arm-linux-gnueabihf/bitcoin-a4e17239ca54-arm-linux-gnueabihf-debug.tar.gz 628265ac50ec6f1e5bb23175975f4da4fb01d4ae1eb935cf42bceab2c228a28f guix-build-a4e17239ca54/output/arm-linux-gnueabihf/bitcoin-a4e17239ca54-arm-linux-gnueabihf.tar.gz fcbf15d734200d05da373c102b26e1ca9bff72177fb7e2624c7f65701ad91e20 guix-build-a4e17239ca54/output/arm64-apple-darwin/SHA256SUMS.part 267297308e1499090f5410d6c6206e581caed37638a4ce2a4f4d91afe787e7cb guix-build-a4e17239ca54/output/arm64-apple-darwin/bitcoin-a4e17239ca54-arm64-apple-darwin-unsigned.tar.gz e84aade8d6b91ff00aefdb060b15ac6884b5954027bc8356deb346a1d221b272 guix-build-a4e17239ca54/output/arm64-apple-darwin/bitcoin-a4e17239ca54-arm64-apple-darwin-unsigned.zip 2d9dc9de892ac7dc7dff5a1ed5205a74569126525b86ed8af47fffafe2be2129 guix-build-a4e17239ca54/output/arm64-apple-darwin/bitcoin-a4e17239ca54-arm64-apple-darwin.tar.gz e20c4ae1abc8d9ce383b65b8b0bdd47575dfd1c059ff6d43a5905e1a4739da96 guix-build-a4e17239ca54/output/dist-archive/bitcoin-a4e17239ca54.tar.gz 75d908891160ee1021d74f4f67faace4dfdd3e4be26e7ec498b1d189e64f7f79 guix-build-a4e17239ca54/output/powerpc64-linux-gnu/SHA256SUMS.part...
Guix Build (x86_64): ```bash a22efc082966018f6ddd17d1a7092ffda56900895dd4694080244257e1c5c974 guix-build-6f0513613a98/output/aarch64-linux-gnu/SHA256SUMS.part ad65ac733f93931c5fcfa09afc2a1f8bed76cd5280be9b569ff9bdf15dec3abe guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu-debug.tar.gz abc9037335e719927525c0474a7959db57a6f3f64d9522474ede4d88e721f73c guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu.tar.gz fdb01866f033273d588340e533840ecfd3d9ed51d91676b3324de3c7a26d114e guix-build-6f0513613a98/output/arm-linux-gnueabihf/SHA256SUMS.part 5873b129b2cf9efc36770a25c7f2315c491368cf30a61ee3677ec6283d64507d guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf-debug.tar.gz eca5831c1cc9e8894fc1b2576530f49e55f02e28e4a5b18712fbe5390c5c2894 guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf.tar.gz 82d1d8a1dd594fe1ac74a9bef6b95b29b9072c9b97170eb415d079d2b23df0dd guix-build-6f0513613a98/output/arm64-apple-darwin/SHA256SUMS.part 87701bec7a281857660cec63f53c5eec2bc1aca613fbc915dbff0832f6fcc048 guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.tar.gz 0061861b901390bcd35998f50a4aebc72cbe0e0d0ba0d6e5a723c25e0df60bd2 guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.zip ee4fb897f7b1edce434b49e33f2d57e8c19609616a2de81b69af7dbe4d3345d1 guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin.tar.gz dd84d6066534402a58247e810214f88488c7d8b63a5c10a70dff63e7b283318c guix-build-6f0513613a98/output/dist-archive/bitcoin-6f0513613a98.tar.gz 1b3e385809dcb62aa07d8ccbe6320f9f3c3da97c2ab3d53cc5f0b29930fa57bf guix-build-6f0513613a98/output/powerpc64-linux-gnu/SHA256SUMS.part 384e0727561e6e26dad72c5921b69b7f3ec2318668d7aa6e73a5075cb31c1225 guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu-debug.tar.gz...
Changed the CI changes here, the win64 job is now `debian:trixie`, which matches Guix with GCC 13.3.0.
I agree. Thanks for the contribution, but we can revisit this (if needed) post-CMake.
> These changes result in a modest performance improvement: I ran the benchmark on an aarch64 machine, and saw mostly worse performance when using the latest GCC, or Clang, with...
I think that rather than trying to micro-optimise these somewhat sensitive functions, if you're interested in benchmarking / performance related changes, your time might be better spent reviewing Pull Requests...
Should this be dropped: https://github.com/bitcoin/bitcoin/blob/5ee6b76c69d51158c13f6ad9ea1b264372e58d4d/src/test/fuzz/fuzz.cpp#L75
Looks like the Apple Clang shipping with Xcode 15, is based on Clang 15. Xcode 16 (still in beta) will ship with a Apple Clang based on Clang 16.
@instagibbs @sr-gi maybe @mzumsande. This will likely affect you. Any feedback?
Closing this given it hasn't received any feedback. I think discussion can continue in (or this branched can be linked to from) #29838.