fanquake

Results 866 comments of fanquake

> Fix the following linter errors observed There are currently no linter errors if you [run the linter using the container](https://github.com/bitcoin/bitcoin/tree/master/test/lint), which installs the same versions as the CI. This...

> This patch also avoids some duplicate work by the person who updates lief later on, who will most likely not see this if it is binned. If someone if...

> I'm guessing your changes here will actually just break the Guix build, given it's still using 0.13.2? ```bash time BASE_CACHE="/base_cache" SOURCES_PATH="/sources" SDK_PATH="/SDKs" ./contrib/guix/guix-build < snip > make[1]: Leaving directory...

> would you be concept ACK on updating the guix manifest to a recent lief (0.14 or maybe imminent 0.15), or prefer to hold off for now? I don't really...

What is the status of this? I think it'd be easiest to just drop the contrib changes. Also no PR description now?

Moved to draft for now, given it's not clear what the status of this is.

Guix build (aarch64): ```bash e7f19ceb7286ff81d1464575418d494dc2143d43cdc8b0e9a1bff7e47cffc773 guix-build-a057869aa3c4/output/aarch64-linux-gnu/SHA256SUMS.part f7e9fa7ada1cc470342e7851862b25a026add7dbd2a441f22327f516268eabb3 guix-build-a057869aa3c4/output/aarch64-linux-gnu/bitcoin-a057869aa3c4-aarch64-linux-gnu-debug.tar.gz 30e3001bf9e9ea03defd21f094887e7c9a5f5b4c95162fbf5ea7d9cbe7458458 guix-build-a057869aa3c4/output/aarch64-linux-gnu/bitcoin-a057869aa3c4-aarch64-linux-gnu.tar.gz 3c520e52f0d0882b2e14d591a8d17cae25501a038bb5a8140654ba406178c72f guix-build-a057869aa3c4/output/arm-linux-gnueabihf/SHA256SUMS.part 92319dc4f32bc295ae366847f9e74e14605d1ec37179e3771b1e9ec4ef6c220e guix-build-a057869aa3c4/output/arm-linux-gnueabihf/bitcoin-a057869aa3c4-arm-linux-gnueabihf-debug.tar.gz f4ebdef64df27da5bfcf63e03e899701ce2b2164a891b5063775fbee2e7a8def guix-build-a057869aa3c4/output/arm-linux-gnueabihf/bitcoin-a057869aa3c4-arm-linux-gnueabihf.tar.gz 644b160459f38549d50447366cdfa20a5ad5fb5a810a513fa0742b8e080f7be2 guix-build-a057869aa3c4/output/arm64-apple-darwin/SHA256SUMS.part e92a26a0cb219d77ba6acecff9df907af9aeb3717833c14632948da1cefbf295 guix-build-a057869aa3c4/output/arm64-apple-darwin/bitcoin-a057869aa3c4-arm64-apple-darwin-unsigned.tar.gz 75ea0be162a822d7ec7fbee6c547107f690d919fbc82679179eb25cd2a8eebc3 guix-build-a057869aa3c4/output/arm64-apple-darwin/bitcoin-a057869aa3c4-arm64-apple-darwin-unsigned.zip 0656688b18b2e167f96699ccf2ad09468c68f34c376ed1dc02dac80420c2f30c guix-build-a057869aa3c4/output/arm64-apple-darwin/bitcoin-a057869aa3c4-arm64-apple-darwin.tar.gz 24a3a1c5a80bd821df79f5958e34d4a8a177b335c98c63b63e73a2ace8e04211 guix-build-a057869aa3c4/output/dist-archive/bitcoin-a057869aa3c4.tar.gz 55abf3736504ac8d273a85fcac304916e0a39bf24c4d9f6af028cf5216e6dfc1 guix-build-a057869aa3c4/output/powerpc64-linux-gnu/SHA256SUMS.part cd9b9a74162b9ac9899b0b0b59cb6cd4482ae9dde1e6d375dea347e1dbbddfdb guix-build-a057869aa3c4/output/powerpc64-linux-gnu/bitcoin-a057869aa3c4-powerpc64-linux-gnu-debug.tar.gz...

@hebasto can you follow up given the gui / translation Qs here. This also needs a rebase.

> It is hard to say because https://github.com/bitcoin/bitcoin/commit/188ca75e5fe4837d16241446558c7566912f67b2 refers to the mentioned test case only. There was no links to any upstream issues. What did you find in the mingw-w64...