fanquake

Results 921 comments of fanquake

https://github.com/bitcoin/bitcoin/actions/runs/12700499877/job/35403281996?pr=31622#step:12:8987: ```bash test 2025-01-10T00:28:24.738000Z TestFramework (ERROR): Assertion failed Traceback (most recent call last): File "D:\a\bitcoin\bitcoin\build\test\functional\test_framework\test_framework.py", line 135, in main self.run_test() File "D:\a\bitcoin\bitcoin\build\test\functional\wallet_taproot.py", line 411, in run_test self.do_test( File "D:\a\bitcoin\bitcoin\build\test\functional\wallet_taproot.py", line...

Closing for now, due to no followup. Please leave a comment, if you want this reopened.

> I'll defer to @fanquake on this one. I'm not too fussed at this point. They may just end up back if we do more from-source builds.

I think this can just be rolled into https://github.com/bitcoin/bitcoin/pull/30664.

General Concept NACK. Anytime we are trying to branch on compiler inside the build system, something is generally going wrong. It's unclear why we need to continue to hard code...

https://cirrus-ci.com/task/4580438562308096?logs=ci#L1723 ```bash Run clusterlin_ancestor_finder with args ['/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz', '-runs=1', PosixPath('/ci_container_base/ci/scratch/qa-assets/fuzz_corpora/clusterlin_ancestor_finder')]INFO: Running with entropic power schedule (0xFF, 100). INFO: Seed: 2205311796 INFO: Loaded 1 modules (615399 inline 8-bit counters): 615399 [0x55b1778f3be8, 0x55b177989fcf),...

https://cirrus-ci.com/task/6556243914915840?logs=ci#L4845: ```bash [09:50:58.842] AssertionError: [node 0] Expected messages "['Error scanning directory entries under']" does not partially match log: ```

Guix Build: ```bash f2e883f15be3d30cc27f1e5ba96ccaa18a9201a242f6dfa7bc65595192249f47 guix-build-1f054eca4e77/output/arm64-apple-darwin/SHA256SUMS.part 53379e0ac143a7c150563ac10973ee7af5dc827e53f96a8b2519cdf1992ece63 guix-build-1f054eca4e77/output/arm64-apple-darwin/bitcoin-1f054eca4e77-arm64-apple-darwin-unsigned.tar.gz 8446ce177d54bac5b185faaecf7a7f34590b512b8ffc690f43d461418196f99c guix-build-1f054eca4e77/output/arm64-apple-darwin/bitcoin-1f054eca4e77-arm64-apple-darwin-unsigned.zip 8839217f2f97adf2ff5c6b88918bd07019dda003d697feb226d0c0a3bf98804e guix-build-1f054eca4e77/output/arm64-apple-darwin/bitcoin-1f054eca4e77-arm64-apple-darwin.tar.gz e77d11cd53af8b37a524ab3b649deb027f530e9ffb9a98ab1f5a276f9f8dcaac guix-build-1f054eca4e77/output/dist-archive/bitcoin-1f054eca4e77.tar.gz ```

> If https://github.com/bitcoin/bitcoin/pull/30838 happens to fix https://github.com/bitcoin/bitcoin/issues/30815, it seems reasonable to switch to NO_SOURCE_PERMISSIONS in all cases for consistency. I'm going to merge this, and we can follow up in...