fanquake
fanquake
Now that the research has been done, it should be added to the commit message and PR description, so it's clear why this change might be safe, or the previous...
> After this and https://github.com/bitcoin/bitcoin/pull/30095, is there any need to keep the thread_local option at all? Maybe not. See #30137.
https://github.com/bitcoin/bitcoin/pull/30095/checks?check_run_id=24909710597 ```bash './'util/threadnames.cpp In file included from /usr/include/string.h:535, from /usr/include/c++/11/cstring:42, from util/threadnames.cpp:7: In function ‘void* memcpy(void*, const void*, size_t)’, inlined from ‘void SetInternalName(std::string)’ at util/threadnames.cpp:50:16, inlined from ‘void util::ThreadSetInternalName(std::string&&)’ at...
> My understanding is that it is safe to use thread_local on FreeBSD for variables that do not have a destructor So if we are moving forward with this assumption,...
The native Windows CI (https://github.com/bitcoin/bitcoin/actions/runs/9112695910/job/25052498545?pr=30122#step:24:64) is failing with: ```bash Run src\bench_bitcoin.exe -sanity-check Running with -sanity-check option, output is being suppressed as benchmark results will be useless. Error: Process completed with...
It'd be good if the commit message could explain why this is being done. It seems like the current approach is just to try and refactor away the Windows bug,...
Removed bugfix given this is a doc/test only change.
Picked this up in #30215, given this is a very straightforward change, that just needed rebase and the commit message fixing.
> website is unavailable now. Forever? Temporarily? Why not use the other official site? Also no mention that this is now downloading a bunch of other stuff that we don't...
Backported to 27.x in #30092.