Fabian Schneider
Fabian Schneider
**Describe the bug** In the MCX adapter, we set the origintype to 0, which corresponds to the origin [1.0, 1.0, 1.0] (MCX documentation: "1 if the origin is [0 0...
- added check if code is executed from simpa package - fixed check against generic paths if a config is already defined in simpa home **Please check the following before...
**Describe the bug** There are two problems with the test_instantiate_when_file_is_in_simpa_home test in test_path_manager.py: 1) If a config in simpa_home already exists it will be used, but it's paths are compared...
**Describe the bug** The kwave adapter uses rot90 to orient the images/volumes for the kwave axis convention. But rot90 does not preserve the original positions in the image. This is...
**Please check the following before creating the pull request (PR):** - [x] Did you run automatic tests? - [x] Did you run manual tests? - [x] Is the code provided...
**Please check the following before creating the pull request (PR):** - [x] Did you run automatic tests? - [ ] Did you run manual tests? - [x] Is the code...
**Please check the following before creating the pull request (PR):** - [x] Did you run automatic tests? - [ ] Did you run manual tests? - [x] Is the code...
**Describe the bug** ``` if global_settings[Tags.DIM_VOLUME_X_MM] < (self.probe_width_mm + global_settings[Tags.SPACING_MM]): self.logger.error("Volume x dimension is too small to encompass MSOT device in simulation!" "Must be at least {} mm but was...
In the initialization of a SlitIlluminationGeometry, the direction_vector_mm is normalized in the following way https://github.com/IMSY-DKFZ/simpa/blob/4b3a63ad250fcb8f9b3cc3f7fba8907e3e9cd61a/simpa/core/device_digital_twins/illumination_geometries/slit_illumination.py#L43-L45 Updating the starting vector for every dimension leads to wrong results, if the input vector...
In k_wave_acoustic_forward_model there is the following check: ``` if not self.component_settings.get(Tags.ACOUSTIC_SIMULATION_3D): detectors_are_aligned_along_x_axis = np.abs(field_of_view[2] - field_of_view[3]) < 1e-5 detectors_are_aligned_along_y_axis = np.abs(field_of_view[0] - field_of_view[1]) < 1e-5 if detectors_are_aligned_along_x_axis or detectors_are_aligned_along_y_axis: simulate_2d...