Fabian Schneider
Fabian Schneider
**Describe the bug** Simulate_3D does not pad the arrays with the gel layer, but still the element_pos accounts for it https://github.com/IMSY-DKFZ/simpa/blob/6278d01a64f886bb92502fe126be90fd75e1be32/simpa/core/simulation_modules/acoustic_forward_module/simulate_3D.m#L103
CLI Bugs
Hey, first of all thanks for this great library, it's a big help. I wanted to report some bugs I encountered when using the CLI to reconstruct a mesh. -...
Hey, this PR fixes some small bugs that caused problems: - Alpha Coefficient can be 0 (kspaceFirstOrder_inputChecking.m:216) - blank_sensor() should return True, if no fields are set and !time_rev (kspaceFirstOrder_inputChecking.m:482)...
Currently the `get_array_binary_mask` and `combine_sensor_data` of the kWaveArray are pretty slow for a large number of array elements. They would benefit from - a general refactor such that expensive functions...
**Is your feature request related to a problem? Please describe.** I was wondering if its possible to parallelize `get_array_binary_mask` and `combine_sensor_data` of the `kWaveArray` class. For simulations with many array...
**Describe the bug** It seems like the x and z axis are switched up in voxel_plot. https://github.com/waltsims/k-wave-python/blob/d4b8e3c0a7d1cef56564783074d6a522aa9f4813/kwave/utils/plot.py#L38C1-L40C40 See screenshots for a comparison between k-wave-matlab, the current behaviour and the "fixed"...
**Please describe your :rocket: feature request.** To potentially improve the reconstruction quality, we could simulate the sensitivity field of the sensor elements and use it for weighting during the reconstruction....
**Please describe your :rocket: feature request.** Currently we only model the sensor frequency response with a gaussian curve (implemented in kwave). Additionally we should add - the true response curves...
**Please describe your :rocket: feature request.** SIMPAs indexing convention is messy: - MCX starts in the middle of voxels - kwave starts add beginning of a voxel, but we need...
**Please describe your :rocket: feature request.** Using k-wave with matlab - requires a license - adds a significant IO overhead to the simulation - makes debugging harder k-wave-python solves these...