simpa icon indicating copy to clipboard operation
simpa copied to clipboard

Wrong normalization in SlitIlluminationGeometry

Open faberno opened this issue 2 years ago • 0 comments

In the initialization of a SlitIlluminationGeometry, the direction_vector_mm is normalized in the following way https://github.com/IMSY-DKFZ/simpa/blob/4b3a63ad250fcb8f9b3cc3f7fba8907e3e9cd61a/simpa/core/device_digital_twins/illumination_geometries/slit_illumination.py#L43-L45

Updating the starting vector for every dimension leads to wrong results, if the input vector is not normalized.

faberno avatar Apr 13 '23 14:04 faberno