removed gel_layer_height in simulate_3D.m

Open faberno opened this issue 2 years ago • 2 comments

Please check the following before creating the pull request (PR):

[x] Did you run automatic tests?
[ ] Did you run manual tests?
[x] Is the code provided in the PR still backwards compatible to previous SIMPA versions?

Provide issue / feature request fixed by this PR

Fixes #237

For now removed the gel_layer_height in the calculation of the element positions, because the gel layer is never padded to the arrays.

Oct 01 '23 13:10 faberno

Actually removing dx * GEL_LAYER_HEIGHT completely can place the sensors outside of the volume. To avoid this we need to add at least dx. But then we should probably add it to all directions.

Oct 06 '23 12:10 faberno

Yes, I guess we should add it to all directions probably in both simulate_2D.m and simulate_3D.m

Jun 25 '24 11:06 kdreher