Franco Meloni

Results 144 comments of Franco Meloni

@yonat-ateam can I see your Dangerfile? Because you are using swift build, but that error comes from the non SPM configuration, so there is something wrong there for sure.

@yonat-ateam given you are using `swift build --target DangerDependencies` are you also importing this framework in your Package.swift, if so can I see that too? If you are using SPM...

With SPM the name of the framework is fixed, so you need to call the library `DangerDeps` (plus optionally any string you want so `DangerDepsMyFramework` for example) in order for...

I've tried it with both `-resultBundlePath build/results` and without it in the xcodebuild command, it works in both cases with XCode 11.2.1

@ecerney I've updated travis on https://github.com/f-meloni/danger-swift-coverage/pull/20 to xcode 11.3, and looks working, then should work in the previous versions too

@el-hoshino Please verify that the path has `.xcresult` at the end, the newer version doesn't work with the folder path PS. You can probably use `ProcessInfo.processInfo.environment["BITRISE_XCRESULT_PATH"]` to get the path

You can exclude targets, but at the moment you can not specify the files. It shouldn't be hard to implement though

Hey 👋🏻 The filter option is been added later than the warning count, so that is not really intended, given they are totally indipendent I would be open to having...

It should support Swift 4.2 https://github.com/f-meloni/EasyToast/blob/master/EasyToast.podspec#L34, maybe the problem is that the podspec is quite old and should now use https://guides.cocoapods.org/syntax/podspec.html#swift_versions?