Franco Meloni
Franco Meloni
Thank you very much for the PR! I was thinking... Now that cocapods 1.7.0 has been released, should it use https://guides.cocoapods.org/syntax/podspec.html#swift_versions?
Yes, sure! :) PRs are always welcome
+1
The deployment is now automated, i would wait to close this issue though for two reasons: - I want to be sure the current solution works well - Shipping the...
You are missing the JENKINS_URL variable, that is mandatory https://github.com/danger/danger-js/blob/master/source/ci_source/providers/Jenkins.ts#L41-L51
Unfortunately there is no support yet for multiple `Package.swift`, Danger searches for the dependencies library into the `Package.swift`, so if it doesn't find any library won't trigger the build of...
Yeah I think adding `--newComment` should work, but in case a workaround might be having a different ID per run (a random generated one).
Do you have danger js 10.6.0 installed? Because it seems to me that is something that should work also on bitbucket server
I saw on your PR ``` // This works though, for some reason SwiftLint.lint(.modifiedAndCreatedFiles(directory:"HymnsTests"), configFile: ".swiftlint.yml", swiftlintPath: "Pods/SwiftLint/swiftlint") ``` I wonder if one of the modified file paths has a...
`File` is just a typealias of `String` ``` /// A simple typealias for strings representing files public typealias File = String ``` Then you can use the array of modified/created...