Franco Meloni

Results 144 comments of Franco Meloni

The trigger should be `pull_request`, that was my first though when I asked for the yaml, I think the `event.json` doesn't contain the pull request data if you don't have...

@orta I remember I've added this https://github.com/danger/danger-js/blob/master/source/ci_source/providers/GitHubActions.ts#L165-L187 To check if the event.json was valid, but apparently the event.json (also looking at the crash message) of that push event, has a...

Yes, that is because swiftlint is really heavy to build, then github actions doesn't build it for you. There are several alternatives: - Release a swiftlint dockerfile as part of...

For using it with SPM: Can you please show me your `Package.swift`? For using it without SPM: try to add ```swift import DangerXCodeSummary // package: https://github.com/f-meloni/danger-swift-xcodesummary.git ``` to your Dangerfile.swift,...

That is technically working I believe, in the sense that Danger-Swift is sending the file and line to Danger-JS (as you can see they are in the comment). The reason...

Can you please show me your `Package.swift`? That error is usualy really common in the SPM configuration when Danger is not linked to a target that can be build before...

Ok, this is really interesting. I think there are two different things to fix then, the first one is find where homebrew saves the installed tools if there is no...

@morluna Yes is been introduced in https://github.com/danger/swift/pull/458 I can make a realease so that can be tested

I've released 3.11.0 with this change

@dhananjaykumardubey seems that the danger library was compiled in a non compatible way. I don't have an Apple Silicon device to try it, but I think that https://github.com/danger/swift/pull/462 might fix...