Franco Meloni

Results 144 comments of Franco Meloni

Does this happen even if you install it via the script?

Sorry for the delay! I totally missed this issue The issue comment function comes from https://github.com/nerdishbynature/octokit.swift so that is probably a good starting point. The dependency was recently updated https://github.com/danger/swift/pull/417,...

What happens if you run `swift run danger-swift local`?

I didn't find an answer to why is not working, I have a really similar configuration on this repo https://github.com/f-meloni/danger-swift-coverage and is working, maybe that could help you to find...

If you locally remove the `~/.danger-swift` folder (that is where marathon's cache is) it will take a lot of time to run danger-swift. It blocks everything, log included. Here some...

The Danger user is not going to see/use any javascript, I think to Danger-js like just an implementation detail, is a binary that is there and you can put somewhere...

I had a quick look at the logs and I saw that danger-js is failing. This _might_ be related to the failure ``` 2019-08-11T21:52:12.5208970Z nvm is not compatible with the...

I can not see any clear reason, @orta do you have any idea?

Yep, I was actually having a look to create a plugin that uses https://github.com/nakiostudio/xcov, will check if I can make it work with that as well.