Franco Meloni

Results 144 comments of Franco Meloni

@alexfu I don't really know what is happening, but Swiftlint seems to have some problems with Linux. I've released a Docker image that has an embedded version of Swiftlint (builded...

@ffried Using a danger official docker image is been discussed on https://github.com/danger/swift/issues/292, and unfortunately that doesn't look a viable option. I created https://github.com/danger/swift/blob/master/.github/workflows/publish_package.yml to automatically publish a GitHub package when...

@ffried https://github.com/f-meloni/danger-swift-swiftlint-action creates a package with the same version that is on docker hub on every tag, then if you want to try, you can use the latest version at...

Hey! Are you setting the GITHUB_TOKEN like this in your action? ``` GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} ``` ? Becuase that should avoid the call to https://api.github.com/user

Actually now danger-js has this code https://github.com/danger/danger-js/blob/fe5f080b4a267012dd80a9d589faee3bd278dc18/source/platforms/github/GitHubAPI.ts#L139 so shouldn't try to get the user if there is `GITHUB_WORKFLOW` and use the default one 🤔

May it be that given it is from a fork it doesn't get the env variables?

I opened https://github.com/danger/swift/pull/468 to try see if it has the same issue or not

In that PR I've seen the error only on Linux, then I've opened https://github.com/danger/swift/pull/469, and I saw that even if it had that issue, it posted on the PR anyway

This makes sense to me, I suppose not always the commit email is associated to bitbucket user.

Hi @tibo, I see you are using `danger-swift` which makes me assume you installed it via brew, if so, which version are you using?