Yingwen

Results 161 comments of Yingwen

> Returns the correct errors from DataFusion. As mentioned in https://github.com/GreptimeTeam/greptimedb/pull/4362#discussion_r1677778154, maybe we can wrap the error into a `BoxedError` before casting to the DataFusion error. Then we can always...

> datanode is doing compaction so that requests are hold until timeout? The engine does compaction in the background so it won't hold requests. The time spent on flushing the...

Feel free to try it. Could you please share your design and steps for implementing this feature?

> And where the proto file to generate `greptime.v1.meta.rs` locates? I cannot find it Are you looking for this? https://github.com/GreptimeTeam/greptime-proto/tree/main/proto/greptime/v1 What's more, we also need to support altering options in...

> should altering table options result in region options being updated cascadingly Yes, we should also support altering region options.

It's recommended to support altering region options first. We don't store the option in the manifest so we can update the [`version`](https://github.com/GreptimeTeam/greptimedb/blob/d628079f4c85c0d3e62991c9d2abb71070e51e31/src/mito2/src/region/version.rs#L218-L244) of the region here if the request is...

@fengjiachun Maybe we can support exporting to object stores.

> Failure occurs with rust-1.79.0 Is it `rust-nightly`? Looks like that we always depend on the latest `rust-nightly` package. We don't support `1.80.0` now. https://github.com/freebsd/freebsd-ports/blob/ce84c5afb89b497aecf69abaf2b7ae34f7ad380c/databases/greptimedb/Makefile#L15-L18 The nightly version of `2024-03-16`...