Yingwen

Results 161 comments of Yingwen

Maybe we could add a query node or a stream adapter to adjust the schemas of streams from different region servers. Currently, the mito engine uses a similar approach to...

> Hi, I noticed that `common_meta::peer::Peer` has more features than `greptime_proto::v1::meta::Peer`, like `std::fmt::Display`. Should I open another pr in this [repo](https://github.com/GreptimeTeam/greptime-proto)? [@v0y4g3r](https://github.com/v0y4g3r) @Wenbin1002 You can try to add the code...

> PeerLookupService in greptimedb You can still define this trait in greptimedb. You can import the Peer from the greptime-proto crate.

> > You can still define this trait in greptimedb. You can import the Peer from the greptime-proto crate. > > I have opened a [pr](https://github.com/GreptimeTeam/greptime-proto/pull/222), PTAL. > > Where...

https://github.com/GreptimeTeam/greptime-proto/pull/222 is merged.

> I'm so sorry that we should map datetime type to microsecond timestamp type, not millisecond type according to #5489. However, we can still replace datetime with timestamp millisecond in...

> > * If we are dealing with Date64 type, we convert it between TimestampMillisecond > > > > I'm so sorry that we should map datetime type to microsecond...

> I'd like to replace with all `datetime` with `timestamp_microsecond`, what do you think? It should be fine.

We are refactoring the `mito` table engine and the implementation hint in the description will soon become outdated. So I self-assign this task first.

If we finish refactoring the datanode, I guess we only need to pass a region id.