Yingwen comments

Results 161 comments of


                                            Yingwen

support alter database compaction options

Do we need to support database level compaction options? @v0y4g3r

Program panic when profiling

Thanks for your report! I guess this is related to https://github.com/tikv/pprof-rs/issues/232

deps: Use opendal's PrometheusLayer directly

> We should consider using the upstream implementation directly and improving it together with community. Sure, we used to have trouble with sharing the same registry between `PrometheusLayer`s because they...

deps: Use opendal's PrometheusLayer directly

Blocked by https://github.com/apache/opendal/issues/4854 and https://github.com/tikv/rust-prometheus/issues/495

Use into_bytes_stream and into_bytes_sink instead of io::copy

https://docs.rs/futures/latest/futures/stream/trait.StreamExt.html#method.forward Then we can use forward to send contents to the sink.

error: casting references to a bigger memory layout than the backing allocation is undefined behavior, even if the reference is unused

Duplicated with https://github.com/GreptimeTeam/greptimedb/issues/4219

Remove `Value::DateTime` and `ValueRef::DateTime`

We may also remove the `DateTimeType` and `DateTimeVector`. So actually we should remove the whole `DateTime` data type from the database.

Optimize count() with time range

> But there is a problem here. When the FileTimeRange of sst is in the range, it can be accumulated directly, but what should be done when the FileTimeRange intersects...

Alter table supports adding or removing columns from primary key

It's not easy to remove an existing column from or add an existing column to the primary key because the order of rows will change. We also assume all rows...

The logical table in the metric engine does not follow the defined column order when insert

The metric engine requires this to ensure the logical table and the physical table have the same column order and the datanode can create the same column id for the...