Yingwen

Results 161 comments of Yingwen

Maybe another related issue: https://github.com/nextest-rs/nextest/issues/1493

The error still exists in the release action...... https://github.com/GreptimeTeam/greptimedb/actions/runs/9114277736/job/25057956421#logs

> The error still exists in the release action...... https://github.com/GreptimeTeam/greptimedb/actions/runs/9114277736/job/25057956421#logs Added a workaround for this in https://github.com/GreptimeTeam/greptimedb/pull/3969

Let's keep this open until https://github.com/nextest-rs/nextest/issues/1493 is fixed so we can upgrade the nextest that contains that patch.

`TRUNCATE` should clear history files. `DELETE FROM` and `TRUNCATE` have different implementations so we recommend using `TRUNCATE` over `DELETE FROM`. > Removes all rows from a table or specified partitions...

When truncate is interrupted by a restart or something else, we may leak some files. We should purge files while opening the region. Reopen this issue as a reminder.

The manifest already tracks files to remove. We could delete these files again while the manifest manager recovers the region.

> But suppose that after this open, delete fails, and `checkpointer::Inner::do_checkpoint` is called and then `ManifestObjectStore::delete_until`, edits will change (now, previous deletes will be successful and no longer need to...

> @evenyag i want to pr LogicalPlan part.I took a rough look. Is it to delete the query::plan file and replace all query::plan::LogicalPlan with datafusion_expr::LogicalPlan? We can still keep the...

You should remove `&self` ```rust fn plan_schema(plan: &DfLogicalPlan) -> Result { let df_schema = plan.schema(); df_schema.clone() .try_into() .context(ConvertDatafusionSchemaSnafu) } ``` I also renamed the function to `plan_schema()` to indicate it...