Yingwen
Yingwen
Thanks for submitting the PR. To remove the wrapper type, we also need to remove the definition of our `LogicalPlan` and use Datafusion's `LogicalPlan` directly. ```rust #[derive(Clone, Debug)] pub enum...
Please fix the compiler errors https://github.com/GreptimeTeam/greptimedb/actions/runs/10000323455/job/27646084014?pr=4384
https://github.com/GreptimeTeam/greptimedb/blob/main/CONTRIBUTING.md#before-pr Please refer to the contributing guide to run all tests and the clippy check locally first. Also please make sure your code can compile.
> * handmade label parsing in protobuf write path We can postpone this. This may not be the bottleneck of Loki write.
@waynexia What do you think?
In another aspect, maybe we should restrict the total row number of an SST file. We don't want to generate a very large parquet file and @v0y4g3r is working on...
Kill will send the connection id. We may need to track the query and link it to the connection id. Refer to: https://github.com/databendlabs/databend/issues/4871
Let's keep it open to track the kill query feature.
> alter database test options ('ttl'='14d', 'compaction.time_window'='1d'); Looks good. > It requires the table to support alter table set options, but it doesn't Should table options have higher priority than...
> @fengjiachun > > > When the region GC worker operates, it retrieves the TTL of the database from DatabaseMetadataManager, merges it with the region's TTL to get the minimum...