Yingwen
Yingwen
@coderabbitai summary
> I prefer to use the struct instead of a hashmap, then we don't need to validate the hashmap everywhere. cc @evenyag @zhongzc [GreptimeTeam/greptime-proto#185 (comment)](https://github.com/GreptimeTeam/greptime-proto/pull/185#discussion_r1768139503) Looks good. We know the...
Maybe we can create a PR to address this in SQLAlchemy. I found that the PostgreSQL dialect lowers the string before getting the schema. https://github.com/sqlalchemy/sqlalchemy/blob/6cf5e2a188fc5e337d22a098a5fe9a9fe10cc7e7/lib/sqlalchemy/dialects/postgresql/base.py#L3756 I'm also considering if we...
Can we add a new method `display_mysql_dialect()` to the `CreateTable` and `Column`? https://github.com/GreptimeTeam/greptimedb/blob/27d9aa0f3be492e4f6e420876193b29f937f6157/src/sql/src/statements/create.rs#L235-L246 We need to map some data types to MySQL's types in `Column`. https://github.com/GreptimeTeam/greptimedb/blob/27d9aa0f3be492e4f6e420876193b29f937f6157/src/sql/src/statements/create.rs#L135-L148 Another way is to...
For #4542, most date/time functions should have an alternative in datafusion, which is compatible with PostgreSQL. https://datafusion.apache.org/user-guide/sql/scalar_functions.html#time-and-date-functions Will it be easier to support PostgreSQL's driver than MySQL? We are working...
> Two version labels still confuse the user. The user has to understand(or we assume the user knows) the format of `app_version`, which is constructed with `branch` and `commit`. It...
What's the purpose of setting this linker?
> Is the SQL syntax expected to look like this? We already have the `parse_vec` function which can parse the vector from a string. Maybe we don't need a `json_to_vec`...
I'll add zh docs after review.
We may need further discussion on how to organize these cache configs. I prefer not exposing to many configs to users.