Esteve Fernandez

Results 331 comments of Esteve Fernandez

@kpturner I hope it's ok with you I submitted this PR, I don't mean to take credit for your work, I've submitted it in the hopes that it'd be easier...

@machulav I've rebased this PR on top of `main` to fix the conflicts. Is there anything that needs to be addressed before being merged? Thanks.

@alonbl I know nothing about Javascript, I only updated #122 and fixed a bug to make it easier for @machulav to merge this PR as we're currently using at the...

@machulav @hvgazula we've been using this branch for the past eight months at the Autoware Foundation without an issue, but I'd prefer it to get merged instead of using our...

@hvgazula it's here https://github.com/esteve/ec2-github-runner/tree/Optionally-execute-runner-as-a-service My fork is just an updated version of @kpturner 's work from https://github.com/machulav/ec2-github-runner/pull/122 plus a couple of minor fixes needed to run as a non-root user.

@mitsudome-r my apologies for the slow response, my notifications were not working properly. I agree on waiting for https://github.com/autowarefoundation/autoware-documentation/pull/180 to be fixed

@mitsudome-r the demo is not working after rebasing these changes on top of main, I'm working on a fix.

@mitsudome-r found the cause for the issue, loaned messages are not supported if using the intra process manager (see https://github.com/ros2/rclcpp/issues/1769), causing the Velodyne component to crash. So the options here...

@mitsudome-r additionally, I can convert other nodes that don't use intraprocess to use the loaned messages API