Esteve Fernandez
Esteve Fernandez
@yukkysaito @mitsudome-r @kaancolak @xmfcx I've rebased this PR and fixed the conflicts, is it still waiting on https://github.com/autowarefoundation/autoware.universe/pull/1200#issuecomment-1217813552 ?
@miursh thanks
@mitsudome-r should I revive this PR? I remember we put this on hold, but can't remember why. Otherwise, it should be closed.
@miursh thanks
> The package name's change and the refactoring had better be separated. Especially, the package name's change has a lot of code changes and has the potential to have a...
@takayuki5168 I've reverted any performance or any other improvements detected by clang-tidy, the CI will now fail because of the clang-tidy check, but now the PR only contains the prefix...
> @esteve Can you fill in the following blanks in the PR's description? > > > Tests performed Done. > > Effects on system behavior These changes do no affect...
@xmfcx @mitsudome-r @kosuke55 @kyoichi-sugahara @mkuri @soblin @maxime-clem @satoshi-ota @shmpwk @taikitanaka3 @takayuki5168 @TomohitoAndo @tkimura4 @rej55 @TakaHoribe @zulfaqar-azmi-t4 This PR is now ready for review. `clang-tidy` reports a warning (a class forward-declared...
> I didn't check in detail but should there be updates made on the https://github.com/autowarefoundation/autoware_launch too? I've checked and there doesn't seem to be any `find-pkg-share` calls, so the changes...
I've reverted any performance or any other improvements detected by clang-tidy, the CI will now fail because of the clang-tidy check, but now the PR only contains the prefix changes.