ec2-github-runner icon indicating copy to clipboard operation
ec2-github-runner copied to clipboard

Published 20 hours ago • verified publisher icon machulav

Parameterise execution of runner (update)

Open esteve opened this issue 1 year ago • 10 comments

This is just https://github.com/machulav/ec2-github-runner/pull/122 rebased on top of main and dist/index.js updated after running npm run package, all credit goes to @kpturner.

I've also fixed a small issue where if the CI job was set to run as a user, and let it download the GitHub runner code, it wouldn't work (see https://github.com/machulav/ec2-github-runner/pull/122#discussion_r1194972979 for context, fix is in https://github.com/machulav/ec2-github-runner/commit/35580d0afba9bc09a2e504ba34491d7079408e53)

esteve avatar May 18 '23 08:05 esteve

@kpturner I hope it's ok with you I submitted this PR, I don't mean to take credit for your work, I've submitted it in the hopes that it'd be easier for @machulav to merge your work more quickly (dist/index.js up to date, fix for runner running as a user).

esteve avatar May 18 '23 08:05 esteve

@kpturner I hope it's ok with you I submitted this PR, I don't mean to take credit for your work, I've submitted it in the hopes that it'd be easier for @machulav to merge your work more quickly (dist/index.js up to date, fix for runner running as a user).

It is fine by me - as long as it helps somebody I am not bothered about who gets the credit :)

kpturner avatar May 18 '23 08:05 kpturner

@machulav I've rebased this PR on top of main to fix the conflicts. Is there anything that needs to be addressed before being merged? Thanks.

esteve avatar Jul 12 '23 10:07 esteve

@alonbl I know nothing about Javascript, I only updated #122 and fixed a bug to make it easier for @machulav to merge this PR as we're currently using at the Autoware Foundation, but if there's any improvements missing, feel free to submit a PR targeting this one, I'm more than happy to incorporate your changes. Thanks!

esteve avatar Jul 19 '23 09:07 esteve

Hello! Any chance this PR will be merged to enable running the ec2 self-hosted runner as non-root?

hvgazula avatar Feb 14 '24 06:02 hvgazula

@machulav @hvgazula we've been using this branch for the past eight months at the Autoware Foundation without an issue, but I'd prefer it to get merged instead of using our fork. Is there any feedback I should address? Thanks.

esteve avatar Feb 14 '24 10:02 esteve

@machulav @hvgazula we've been using this branch for the past eight months at the Autoware Foundation without an issue, but I'd prefer it to get merged instead of using our fork. Is there any feedback I should address? Thanks.

Thank you for replying @esteve. Is it on the main branch of your fork? I agree it'd be nice to have this feature merged in here. I'll ask this again for attention :). @machulav any chance you can merge this feature?

hvgazula avatar Feb 14 '24 13:02 hvgazula

@hvgazula it's here https://github.com/esteve/ec2-github-runner/tree/Optionally-execute-runner-as-a-service

My fork is just an updated version of @kpturner 's work from https://github.com/machulav/ec2-github-runner/pull/122 plus a couple of minor fixes needed to run as a non-root user.

esteve avatar Feb 14 '24 14:02 esteve

Thanks, @esteve. It worked.

hvgazula avatar Feb 14 '24 17:02 hvgazula

@machulav we also need to run specs as a non-root user, it would be great to see this merged

thimios avatar Apr 16 '24 14:04 thimios