Esteve Fernandez

Results 331 comments of Esteve Fernandez

@kenji-miyake @yukkysaito @aohsato @miursh this is now read for review, but I have a question about how to store RGB values (see https://github.com/autowarefoundation/autoware.universe/pull/1200#discussion_r915939898)

I've updated this PR after the sync branch has been merged, unfortunately flume depends on spinning_top, which uses the newer spin_loop API (https://github.com/rust-osdev/spinning_top/blob/master/src/spinlock.rs#L57). I could submit a patch to spinning_top...

@OscarTHZhang I ran into the same problem. One solution I found is to link the imported corrosion target against `libz` in your `CMakeLists.txt`. For example: ```cmake corrosion_import_crate(MANIFEST_PATH rust/Cargo.toml) target_link_libraries(MY_CORROSION_CRATE INTERFACE...

@alexcrichton @joshtriplett this ticket should be ok to close with the solution I provided in https://github.com/rust-lang/flate2-rs/issues/281#issuecomment-1207277303

@nnmm what is the rationale for this? I don't really see the point, is it to get rid of `SubscriptionHandle`? On a general note, if this gets approved, I'd like...

> but I think this generalization is a good thing How would that work with `GuardCondition`s? They are entities that are added to a waitset, but behave differently than subscriptions,...

> ```rust > trait ClientBase : Waitable {} > ``` > That's a bit more type-safe. Though maybe `ClientWaitable` would be a better name. Good idea! I like it, in...

> Are you ok with keeping the `Waitable` name as well? Yeah, that's fine, makes total sense.

This one might be a bit tricky, but doable anyway. The tricky part is that in `rclcpp` and `rclpy`, nodes inherit from `Node`, which obviously we can't in Rust. The...

@jhdcs for now I'd just port the `rclcpp` / `rclpy` API 1:1 as a first step, but then offer the possibility to integrate with `async_std`, `tokio`, etc. so that existing...