Esteban Kuber
Esteban Kuber
I agree with what's been said. I think the important part is making sure that there's *intent* behind what the library author is doing *and* to have a reference on...
I like the way you've presented things and make a good argument for it. I *am* slightly concerned with users drawing an incorrect relationship between generators and match arms, but...
I don't think there would be any difference between `gen {}` and `gen || {}`.
Is it necessary? No. Because of `async`, there's an expectation that people scan the `fn` head to identify what the function does. If we only rely on a contextual keyword...
This seems like a reasonable compromise, also giving an affordance to the user to also assert a specific kind of `Iterator` being returned (like `DoubleEndedIterator`). I was trying to hide...
What's the benefit or the Builder type being available to begin with? What's the user benefit of that? I'm trying to understand the usecase, particularly because if the field types...
I see, that makes sense.
Makes sense. I'll merge any PRs that implement this.
No blockers, initial release was somewhat haphazard. I can maybe do this soonish, but if you submit a PR with the change to https://github.com/estebank/makeit/blob/main/makeit/Cargo.toml#L20, I'll merge them and republish.
> Isn't squash done on merge or something like that? We don't squash on merge.