Esteban Kuber comments

Results 157 comments of


                                            Esteban Kuber

Reserve `gen` keyword in 2024 edition for `Iterator` generators

> I think instead we can sidestep the issue by describing "here are the patterns that we know must work" (e.g., for x in generator() { ... }) and here...

Fix println! ICE when parsing percent prefix number

@bors r+

Is it normal that to_string() for bigint takes so much(8-10 mins)?

Would the project consider accepting a PR that changes [the `BigInt` type](https://github.com/rust-num/num-bigint/blob/f09eee83f174619ac9c2489e3feec62544984bc5/src/bigint.rs#L61-L65) to be [something along the lines of](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=cd30cf23d1267776bf5088f43334837a) ```rust pub struct BigInt { sign: Sign, data: BigUint, formatter: PhantomData,...

Is it normal that to_string() for bigint takes so much(8-10 mins)?

@cuviper would the prior suggestion of a new method with conditional formatting predicated on a length check be acceptable instead?

Note for E0599 if shadowed bindings has the method.

There are a few typos in the comments and formatting issues that `./x.py fmt` didn't seem to pick up/complain about, but if that's the case it's fine to land and...

Add x86_64-unknown-linux-none target

@Nilstrieb do you want to snipe this review? I won't be around for a few days and this seems out of my wheelhouse. @workingjubilee thank you for taking on digging...

On trait bound mismatch, detect multiple crate versions in dep tree

@weiznich [added a note about `cargo tree`, but it gets somewhat lost in the noise](https://github.com/rust-lang/rust/pull/124944/files#diff-4070e8fafbce87b6f888eddd3efd65d37450b862616a417be2b8d3f6bdce6424) :-/

On trait bound mismatch, detect multiple crate versions in dep tree

@fee1-dead added test

On trait bound mismatch, detect multiple crate versions in dep tree

Need to fix the tests, clearly they worked because of dirty environment only. I'll fix them.

Inherent static methods on traits do not play well with associated types

Current output: ``` error[E0191]: the value of the associated type `Ty` in `Assoc` must be specified --> src/main.rs:10:10 | 2 | type Ty; | ------- `Ty` defined here ... 10...