Esteban Kuber
Esteban Kuber
Yes, squashing and force pushing as the last step of a PR review that might have had some "unnecessary" history is best practice. We don't auto-squash because in some cases...
You'll have to rebase on top of a more recent version of the repo before we can merge.
@lyming2007 that might work as well, but I'd like to see what it looks like in the terminal, as too much text density can affect readability. The `note` for example...
@lyming2007 that seems very close! I'll add comments in the PR.
@bors try @craterbot check
@bors try @craterbot check
@craterbot check