Esteban Kuber
Esteban Kuber
Oh! There's platform specific text :-/ You'll have to make these tests use "revisions" targeting windows and linux separately in the same file.
@oli-obk I'll take your ✅ as r+ @bors r=oli-obk
I feel like we would want to unconditionally suggest updating for nightly releases. On stable I am of many minds. We could do a check for current date and try...
@jieyouxu let's check if `rustc_feature::UnstableFeatures::from_environment(None).is_nightly_build()` works for checking that the ICE isn't happening on a stable release. If it doesn't work, lets land this PR as is.
> For macros from other crates the spans are still collapsed to a single call site span, this way we don't jump to code of println! and other macros from...
@bors r+