Eric StJohn

Results 305 comments of Eric StJohn

Looks like we now have some warnings as errors on x86. That's noticing our intentional truncation - where before the truncation happened in the loop bounds as potentially infiinite loop....

Source of this appears to be https://github.com/dotnet/roslyn/blob/0068ee9ac48a9c3d19410cdea20474f5cdf2e7f1/src/Workspaces/Core/MSBuild.BuildHost/Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.csproj#L33 @tmat do you happen to know why this is redistributed still but other MSBuild dependencies are not?

Could you pick it up from the SDK instead - or make the SDK responsible for producing the final layout and deps file like it does for other tools? The...

@marcpopMSFT - does this sound like something the SDK does for other apps/layouts like MSBuild and other tools? Maybe you just need to give BuildHost that same treatment?

It could ... though I thought there was a specific reason for staying on net6.0. If you could multi-target to net9.0, update to an MSBUild version without problematic out of...

I've confirmed that with the latest fixes from @tmat this is no longer a problem. I scanned build 20241024.1-9.0.100-rtm.24523.42-243834 and it doesn't have any mention of 8.x System.Text.Json. Thank you...

@michaelgsharp will this be addressed with https://github.com/dotnet/machinelearning/pull/7282?

I updated the description with your feedback. > We should include that PaxTarEntry also no longer includes these timestamp. This is for consistency with other tools (and GnuTarEntry). I see...

> we have assemblies without UI components which should do not need a framework reference to Microsoft.WindowsDesktop.App It sounds to me like you're trying to consume a library built for...