Eric StJohn

Methodical_others test JIT/Methodical/Coverage/copy_prop_byref_to_native_int crashing

8

Failures 7/5-8/5 (incl. PRs) based on Runfo in [last 30 days](https://runfo.azurewebsites.net/search/tests/?q=started%3A%7E30+definition%3Aruntime+name%3A%22methodical_others+work+item%22): Day | Run | Failure -- | -- | -- 8/4 | PR #73174 - [1923945](https://runfo.azurewebsites.net/view/build/?number=1923945) | Crash dump...

Update .NET libraries and runtime dependencies

3

Update to the latest libraries for all dependencies of ML.NET that come from dotnet/runtime (and prior) repositories. I noticed that the dependency on `PlatformAbstractions.RuntimeEnvironment.GetRuntimeIdentifier();` was broken because DependencyModel stopped referencing...

PR validation regularly fails with ``` Microsoft.ML.Tests.ImageTests.TestBackAndForthConversionWithoutAlphaNoInterleaveNoOffset [FAIL]  System.ArgumentException : Parameter is not valid.  Stack Trace:  at System.Drawing.SafeNativeMethods.Gdip.CheckStatus(Int32 status)  at System.Drawing.Bitmap.UnlockBits(BitmapData bitmapdata)  /__w/1/s/src/Microsoft.ML.ImageAnalytics/VectorToImageTransform.cs(421,0): at Microsoft.ML.Transforms.Image.VectorToImageConvertingTransformer.Mapper.c__DisplayClass5_0`1.b__0(Bitmap&...

MSTest.TestAdapter should target newer TargetFrameworks

3

## Description Today MSTest.TestAdapter targets old and out of support target frameworks, resulting in a lot of unnecessary dependencies being downloaded. ## Steps to reproduce Reference MSTest.TestAdapter in a `net6.0`...

xUnit2002 flags a literal int that's being cast to a reference type as not nullable

1

Build the following project which does this: ```c# Assert.NotNull((JsonValue?)(int?)42); ``` The cast here should treat that `int` as a nullable reference type `JsonValue`. It's possible for a badly implemented conversion...

Assert.Equal(float, float, float) introduced a source breaking change

1

The addition of this API: https://github.com/xunit/assert.xunit/commit/8e86f1d10f2a38acbb9bf6fc5a4f19b583ca1939 ``` public static void Equal(float expected, float actual, float tolerance) ``` Created an ambiguity for code that was calling `Assert.Equal(float, float, int)` Here's a...

Assert.Throws<ArgumentException>(paramName:null, Action) throws ArgumentNullException

2

Regression introduced here: https://github.com/xunit/assert.xunit/commit/726e48276895ecba39468990809664948113d876#diff-829bc159adac0f20073a5979fa4b4db6d7586a249058328199b486cf26b01070R189 Observed in xUnit 2.4.2-pre.13 For better or worse, we have framework code that doesn't specify a parameter name for some `ArgumentException`s. EG: https://github.com/dotnet/runtime/blob/57bfe474518ab5b7cfe6bf7424a79ce3af9d6657/src/libraries/System.Drawing.Common/tests/FontFamilyTests.cs#L63-L64 Specifying `null` for...

Consider a test which wishes to check that a public const does not change. The API being tested is https://github.com/dotnet/runtime/blob/355a8cf12b21d81248aa8f5fc7ca2544e4a63db5/src/libraries/System.Private.CoreLib/src/System/CodeDom/Compiler/IndentedTextWriter.cs#L20 ``` public const string DefaultTabString = " "; ``` The...

Potential feature: APIPort helper when nuget resolves an assembly from a different TFM

2

/cc @terrajobst See https://github.com/NuGet/Home/wiki/Enable-.NET-Core-2.0-projects-to-work-with-.NET-Framework-4.6.1-compatible-packages When NuGet uses AssetTargetFallback to resolve an assembly from a different framework on the current one, wouldn't it be nice to have a helper that could...

For example: DirectoryInfo.FullName. On desktop this is: ```C# public class FileSystemInfo { public virtual string FullName { get; } } public class DirectoryInfo: FileSystemInfo { public override string FullName {...