machinelearning icon indicating copy to clipboard operation
machinelearning copied to clipboard

Update libmf submodule and reenable CodeQL on it

Open ericstj opened this issue 1 year ago • 2 comments

ericstj avatar May 23 '24 18:05 ericstj

Looks like we now have some warnings as errors on x86. That's noticing our intentional truncation - where before the truncation happened in the loop bounds as potentially infiinite loop. I'll need to make another change to libmf to fix this.

ericstj avatar May 23 '24 18:05 ericstj

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.65%. Comparing base (4d1a8c0) to head (6a03258). Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7159      +/-   ##
==========================================
- Coverage   68.92%   68.65%   -0.27%     
==========================================
  Files        1396     1262     -134     
  Lines      266745   257767    -8978     
  Branches    27560    26660     -900     
==========================================
- Hits       183849   176976    -6873     
+ Misses      75792    73978    -1814     
+ Partials     7104     6813     -291     
Flag Coverage Δ
Debug 68.65% <ø> (-0.27%) :arrow_down:
production 62.93% <ø> (-0.59%) :arrow_down:
test 88.85% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 142 files with indirect coverage changes

codecov[bot] avatar May 23 '24 19:05 codecov[bot]