Eric StJohn

Results 305 comments of Eric StJohn

@tommcdon @hoyosjs - can you help triage this? Does this belong in runtime or should it go somewhere else? I'm not sure where this responsibility lies.

Who needs to take action on this to fix it? Can you tag them?

/ba-g only failing test is green but BuildAnalysis didn't flip the build to pass. It seems to be double-counting the failing test as a build failure. Opened https://github.com/dotnet/machinelearning/issues/7344

It looks like you might have missed helix.proj and codecoverage.proj. These files aren't built by the root build scripts. You can restore them with `dotnet restore` on the project itself....

Well my whole point of that question was that it must apply a sort of some kind if the *only* source of non-determinism in the build of the entire dotnet...

I've addressed all feedback, please have another pass at this. Thank you.

@JakeRadMSFT @LittleLittleCloud -- is it possible that modelbuilder is deploying the wrong binaries in this case? I do think a standalone app should be able to work here.

@dsplaisted essentially we are creating our own shared framework but none of the runtime items are ever visible to conflict resolution and we need to decide what the best way...

Looks like this has the mac update that breaks libomp. Will require backporting https://github.com/dotnet/machinelearning/commit/d070dcb26c4222466ae40744678ce8077242805f