Eric StJohn

Results 305 comments of Eric StJohn

Adding to global.json is about stating the minimum required. You should be using it for the same reasons[ you recommend folks use NuGet PackageReferences with Versions](https://learn.microsoft.com/en-us/nuget/concepts/package-versioning?tabs=semver20sort#best-practice). For folks like us...

In addition to this, it downloads all of these and builds everything again in the test jobs before then uploading to helix 🙃 Probably this can be cut in half....

The removal of `Dispose` methods was also a binary breaking change. I was able to workaround that by casting these objects to their `SafeHandle` types then calling Dispose on those,...

I tried to rollback to version 0.110.1 (before the removal of the strong name) and it also doesn't work, failing at runtime with: ``` Could not load file or assembly...

@filipnavara did you have a chance to look at this to see if there's a fix you'd propose? The repro you shared looks like it would just be a SendMessage...

It is `WindowsFormsSynchronizationContext` that's deciding to push work to a blocked thread. It's unusual to me that WinForms isn't on the stack at all on the main thread. Is that...

I'd like to better understand what's expected from the Winforms side of things here. @JeremyKuhne shouldn't `WindowsFormsSynchronizationContext` be able to know when it's waiting on work that will never get...

I met with @JeremyKuhne and @lonitra and they feel that it's possible that this is being caused by the same root cause as https://github.com/dotnet/winforms/pull/9861. That bug would have made it...

@filipnavara are you still hitting this? We haven't seen other reports.

I see. I ran your repro on the latest 9.0 bits and it does indeed still hang. Here's the hang: ``` 00 00000022`971ff188 00007ffc`9e23f65b 0x00007ffd`80fe7ef0 01 00000022`971ff190 00007ffc`9e24621e System_Windows_Forms!System.Windows.Forms.Control.WaitForWaitHandle+0x9b [/_/src/System.Windows.Forms/src/System/Windows/Forms/Control.cs...