Eric StJohn

Sorry for the delay here, I'll have a look and see what failures you're hitting and figure out how we can get this working. Thank you for your contribution -...

CI failures are all due to packages not mirrored to our build feeds. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1066692&view=logs&j=80b813b5-9a08-5859-11a8-dc0e5b556e52&t=99848337-6ccc-53eb-9c14-1b676ae001b9 ``` /__w/1/s/src/Microsoft.ML.Console/Microsoft.ML.Console.csproj : error NU1101: Unable to find package MethodBoundaryAspect.Fody. No packages exist with this id...

Ok, I think this addresses all the feedback. @Crichen Can you have a look at what I did and see if this still would work for you? If so we...

..NET Framework tests are not failing, but crashing on exit. Finalizer seems to ~be double-disposing~ accessing another object outside it's graph which has already been finalized/disposed. ``` Unhandled exception: System.ObjectDisposedException:...

Sigh, that's this ThreadLocal https://github.com/SciSharp/TensorFlow.NET/blob/0ee50d319e5539f15b13f8909fd246c18819d840/src/TensorFlowNET.Core/tensorflow.cs#L47 Which is accessed in the finalizer -- https://github.com/SciSharp/TensorFlow.NET/blob/0ee50d319e5539f15b13f8909fd246c18819d840/src/TensorFlowNET.Core/Sessions/BaseSession.cs#L301 That'll fail if the TF object and it's ThreadLocal's are finalized first. This bug was introduced in...

I wonder if we just pick up 0.100.4 and then patch it to set the `_status` value of the session.

I think I have worked around all the crashes. What's happening is buggy finalizer in TF for Session will sometimes crash - depending on the order that the GC decides...

I did a scrub of the TF.NET Codebase for other instances of crashing finalizers. I found one in `EagerResourceDeleter` but we don't use that. Just so happens that was already...

@Crichen - bumping this in case you are back from holiday. If you're happy with the changes we can merge this.

Sounds good. I really wish we could move to the latest Tensorflow.NET, but those breaking changes around strong-name signing are a real blocker for us. At least we are able...